Dan Kenigsberg has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34637/1//COMMIT_MSG Commit Message: Line 2: Author: Ondřej Svoboda <[email protected]> Line 3: AuthorDate: 2014-10-30 11:41:04 +0100 Line 4: Commit: Ondřej Svoboda <[email protected]> Line 5: CommitDate: 2014-10-30 11:41:04 +0100 Line 6: When was this added to kernel? Line 7: bondopts: Add defaults for the 'arp_all_targets' option Line 8: Line 9: This option would be output even if it had a default value, which is harmless Line 10: but not desired. netinfoTests:testGetBondingOptions, whose purpose is to alert Line 5: CommitDate: 2014-10-30 11:41:04 +0100 Line 6: Line 7: bondopts: Add defaults for the 'arp_all_targets' option Line 8: Line 9: This option would be output even if it had a default value, which is harmless I don't understand the first complex sentence. Could you rephrase in multiple short sentences? Line 10: but not desired. netinfoTests:testGetBondingOptions, whose purpose is to alert Line 11: us that we are missing some defaults, should now pass again. Line 12: Line 13: Change-Id: I26874003ab5fe4f4fbe92805ea78b7823b742074 -- To view, visit http://gerrit.ovirt.org/34637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26874003ab5fe4f4fbe92805ea78b7823b742074 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
