Dan Kenigsberg has posted comments on this change. Change subject: vm: migration: move wait countdown in a function ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/32706/5//COMMIT_MSG Commit Message: Line 9: The Downtime thread is a migration helper thread Line 10: which is in charge of periodically updating the Line 11: migration downtime. Line 12: Line 13: This thread blindly does a configurabile number configurabile -> configurable Line 14: of steps, and after each step it updates the Line 15: downtime according to a given law. Line 16: Line 17: Between each step, it waits for a number of http://gerrit.ovirt.org/#/c/32706/5/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 361: for i in range(steps): Line 362: yield int(offset + base ** i) Line 363: Line 364: Line 365: def linear_wait(mem_size, delay, steps): for me, calling the second arg delay_per_gib would improve readabilty. Alternatively, it can be hidden inside the function; I'm not sure of the merits of DELAY_PER_GIB. Line 366: wait = (delay * max(mem_size, 2048) + 1023) / 1024 Line 367: Line 368: for _ in range(steps): Line 369: yield wait / steps -- To view, visit http://gerrit.ovirt.org/32706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id808539a654e1556519ed54f6f4b67364eacf48a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
