Nir Soffer has posted comments on this change.

Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same 
subnet
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 186:                     key = "node.session." + key
Line 187:                     iscsiadm.node_update(iface.name, portalStr, 
target.iqn,
Line 188:                                          key, value, hideValue=True)
Line 189: 
Line 190:             if iface.netIfaceName:
> Or, better, I will probe the os device using netinfo.getRouteDeviceTo() and
Can you describe in more details why changing the rpfilter does not work when 
adding the second session? How can we reproduce this issue?
Line 191:                 supervdsm.getProxy().setRpFilter(iface.netIfaceName,
Line 192:                                                  
_SYSCTL_RPFILTER_LOOSE)
Line 193: 
Line 194:             iscsiadm.node_login(iface.name, portalStr, target.iqn)


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: jian wang <wjia...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to