Francesco Romani has posted comments on this change. Change subject: utils: Add changehash function for change detection ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/33045/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1169: h = hashlib.md5() Line 1170: for s in strings: Line 1171: h.update(s) Line 1172: # Engine stores this in varchar(30) Line 1173: return h.hexdigest()[:30] I wonder if this alter the properties of the hash like the distribution. IIRC it should not, and a quick google search seems to confirm http://stackoverflow.com/questions/8184941/uniform-distribution-of-truncated-md5 -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2242a594383e2d2fe64e3a581f18b8ac662648b0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
