Antoni Segura Puimedon has posted comments on this change. Change subject: libnl: non-existing link exception ......................................................................
Patch Set 6: Code-Review-1 (1 comment) Just one minor thing. http://gerrit.ovirt.org/#/c/34690/6/lib/vdsm/netlink/link.py File lib/vdsm/netlink/link.py: Line 141: else: Line 142: err = _rtnl_link_get_kernel(sock, index, name, byref(link)) Line 143: if err or link is None: Line 144: if -err == _NLE_NODEV or link is None: Line 145: if name is not None: Please, swap the options: if name is None: raise IOError(errno.ENODEV, 'Dev with index %s is not present in the ' % 'system' % index) else: raise IOError(errno.ENODEV, '%s is not present in the system' % name) Line 146: raise IOError(errno.ENODEV, '%s is not present in the system' % Line 147: name) Line 148: else: Line 149: raise IOError(errno.ENODEV, 'Dev with index %s is not present ' -- To view, visit http://gerrit.ovirt.org/34690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cf5c7d1cb89bb77402b6e3d23fb0e76f06e122e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
