Francesco Romani has posted comments on this change. Change subject: utils: faster albeit less general deepcopy ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/34989/6/tests/utilsTests.py File tests/utilsTests.py: Line 644: self.assertEqual(utils.picklecopy(VM_STATUS_DUMP), Line 645: copy.deepcopy(VM_STATUS_DUMP)) Line 646: Line 647: def test_picklecopy_faster(self): Line 648: stmt = """ > I would call this "setup". Done Line 649: import copy Line 650: from vdsm import utils Line 651: import vmTestsData Line 652: """ http://gerrit.ovirt.org/#/c/34989/6/tests/vmTestsData.py File tests/vmTestsData.py: Line 228: 'device=ide, type=CONTROLLER, bootOrder=0, specParams={}, ' Line 229: 'address={bus=0x00, domain=0x0000, type=pci, slot=0x01, ' Line 230: 'function=0x1}, managed=false, plugged=true, readOnly=false, ' Line 231: 'deviceAlias=ide0, customProperties={}, snapshotId=null, ' Line 232: 'logicalName=null}', > This looks wrong - are you sure the contents of the custom devices is corre This is not the output of the first startup of a VM, hence Engine's stored device data comes into play here. Most likely this data becomes fancily mangled in the VDSM->Engine->DB path, but this is just guesswork. For the sake of this test, it doesn't really matter since the flow is identical comparing all the call to status(). About the device name mangling, yes: this looks wrong but never heard reports of malfunctioning due to this. Apparently this is there from a long time, I remember to have it seen first in late 3.4 cycle. I'd like to investigate that but because I never got report of failures even vaguely related to this, it always slipped behind more urgent/important issues. Line 233: 'device_4cf4bc50-87c6-44a1-b382-339929ed8350' Line 234: 'device_bb36a3fe-5333-4a66-9708-ef7dc5dca461': Line 235: 'VmDevice {vmId=56f693d4-2245-444a-a4e8-fcc5bbd08350, ' Line 236: 'deviceId=bb36a3fe-5333-4a66-9708-ef7dc5dca461, ' -- To view, visit http://gerrit.ovirt.org/34989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936a977e9f41863bdff18b9343d252ab0996d554 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
