Shahar Havivi has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 19: (4 comments) http://gerrit.ovirt.org/#/c/33309/19/tests/v2vTests.py File tests/v2vTests.py: Line 24: from testlib import VdsmTestCase as TestCaseBase Line 25: from monkeypatch import MonkeyPatch Line 26: Line 27: Line 28: class VmMock(object): > I'd rather extend/use vmfakeslib Answer down... Line 29: def name(self): Line 30: return 'windows' Line 31: Line 32: def state(self, flags=0): Line 65: </devices> Line 66: </domain>""" Line 67: Line 68: Line 69: class LibvirtMock(object): > same The reason I choose to make this classes here is the above domain xml that will be used only for v2v test, If I will extend vmfakelib.Connection I need to add the listAllDomains() method that will need to initialized vmfakelib.Domain with the above domain xml. I didn't want to hardcoded the xml in vmfakelib... I don't see workaround for that now - will be glad to hear suggestions. Line 70: def close(self): Line 71: pass Line 72: Line 73: def listAllDomains(self): http://gerrit.ovirt.org/#/c/33309/19/vdsm/virt/vmstatus.py File vdsm/virt/vmstatus.py: Line 34: Line 35: UNKNOWN = 'Unknown' Line 36: BLOCKED = 'Blocked' Line 37: CRASHED = 'Crashed' Line 38: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended' > please merge this new group with the existing one, and make Done Line 39: Line 40: statusMsg = {libvirt.VIR_DOMAIN_NOSTATE: UNKNOWN, Line 41: libvirt.VIR_DOMAIN_RUNNING: UP, Line 42: libvirt.VIR_DOMAIN_BLOCKED: BLOCKED, Line 36: BLOCKED = 'Blocked' Line 37: CRASHED = 'Crashed' Line 38: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended' Line 39: Line 40: statusMsg = {libvirt.VIR_DOMAIN_NOSTATE: UNKNOWN, > I'd rather use 'statuses', following the line of 'vmexitreason.py'. It shou Done Line 41: libvirt.VIR_DOMAIN_RUNNING: UP, Line 42: libvirt.VIR_DOMAIN_BLOCKED: BLOCKED, Line 43: libvirt.VIR_DOMAIN_PAUSED: PAUSED, Line 44: libvirt.VIR_DOMAIN_SHUTDOWN: POWERING_DOWN, -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
