Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: replace old ipwrapper event monitor ......................................................................
Patch Set 10: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/34929/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 191: yield Line 192: finally: Line 193: mon.stop() Line 194: changes = [(event.device, event.state) for event in monitor Line 195: if event.device == device] this needs to work with dictionaries now! we are not making named tuples anymore. Line 196: for _, state in changes: Line 197: if state != originalState: Line 198: raise OperStateChangedError('%s operstate changed: %s -> %r' % Line 199: (device, originalState, changes)) http://gerrit.ovirt.org/#/c/34929/10/tests/ipwrapperTests.py File tests/ipwrapperTests.py: Line 122: Line 123: ipwrapper.getLink(self._bridge.devName).promisc = False Line 124: self.assertFalse(ipwrapper.getLink(self._bridge.devName).promisc, Line 125: "Could not disable promiscuous mode.") Line 126 In the previous patch you should have put similar tests to this one. -- To view, visit http://gerrit.ovirt.org/34929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7a9765e59a8392fff9b3fd556133159aeb60b1c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
