Antoni Segura Puimedon has posted comments on this change. Change subject: network: synced configs ......................................................................
Patch Set 10: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/35031/10/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 159: self._addSourceRoute(nic) Line 160: if nic.bond is None: Line 161: if not netinfo.isVlanned(nic.name): Line 162: ifdown(nic.name) Line 163: ifup(nic, nic.ipConfig.async) do the monitoring around this. Line 164: Line 165: def removeBridge(self, bridge): Line 166: DynamicSourceRoute.addInterfaceTracking(bridge) Line 167: ifdown(bridge.name) Line 837: ordered_conditions.append({'name': iface.name, 'qdisc': None, Line 838: 'flags': 70723, 'event': 'new_link'}, Line 839: {'name': iface.name, 'state': 'up', Line 840: 'flags': 70723, 'event': 'new_link'}) Line 841: if iface.ipConfig.ipaddr is not None: if it has ipaddr or ipv6addr we don't need to check link conditions (as defined above) Line 842: conditions.append({'name': iface.name, 'family': 'inet', Line 843: 'address': iface.ipConfig.ipaddr, Line 844: 'event': 'new_addr'}) Line 845: if iface.ipConfig.ipv6addr is not None: Line 868: raise Line 869: except: Line 870: raise Line 871: else: Line 872: for m in mon: for event in mon Line 873: for i in conditions: Line 874: try: Line 875: if all([conditions[i][k] == m[k] Line 876: for k in conditions[i].keys()]): -- To view, visit http://gerrit.ovirt.org/35031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b16cef3afba2c5b46efd45529823b879e98f1e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
