Dan Kenigsberg has posted comments on this change.

Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33871/4/vdsm.spec.in
File vdsm.spec.in:

Line 160: Requires: libguestfs-tools-c >= 1:1.26.7-2
Line 161: %endif
Line 162: 
Line 163: %ifarch ppc64
Line 164: %define libvirt_version 1.2.2
Does this split really help? Would el7-for-ppc ship a different libvirt version 
than that in x86? This would surprise me quite a bit.
Line 165: %else
Line 166: %define libvirt_version 1.1.1
Line 167: %endif
Line 168: 


-- 
To view, visit http://gerrit.ovirt.org/33871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to