Petr Horáček has posted comments on this change. Change subject: Fixed parted utils for newer parted ......................................................................
Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/35700/3//COMMIT_MSG Commit Message: Line 9: In the newer parted, the new flag 'esp' is added to the 'boot' flag on all Line 10: partitions. Line 11: Line 12: Also fixed issue where we returned the trailing commas when a partition had Line 13: more than one flag. it is not related to the newer parted, right? maybe it should be split into two patches Line 14: Line 15: Change-Id: I21b5842abb03f08b15b067c0c6e5889091bcdc5d http://gerrit.ovirt.org/#/c/35700/3/vdsm/parted_utils.py File vdsm/parted_utils.py: Line 42: freeRegionList.append((region.start, region.end, Line 43: region.length, freeBytes)) Line 44: partitions = {} Line 45: for partition in partedDisk.partitions: Line 46: partitionFlags = [ i'd feel better if you'd save three lines and write brackets directly before and after the comprehension :) Line 47: flagname for (flag, flagname) Line 48: in parted.partition.partitionFlag.items() Line 49: if partition.getFlag(flag) Line 50: ] -- To view, visit http://gerrit.ovirt.org/35700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21b5842abb03f08b15b067c0c6e5889091bcdc5d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
