Dan Kenigsberg has posted comments on this change. Change subject: There is no need to decorate all tests with ValidateRunningAsRoot ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36049/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-12-10 11:17:36 +0200 Line 6: Line 7: There is no need to decorate all tests with ValidateRunningAsRoot Line 8: Line 9: This is since setupModule already requires root previliges when Actually, setupModule does not require root. It uses sudo to load the dummy module. Even though (too many?) of our tests require root to create veth devices or whatever, I'd like to be able to run at least SOMETHING as an unprivileged user, and hope that some time in the future we can have everything run like that. (E.g. prepare one veth pair at module setup time, and use it all over?) Line 10: Adding dummy links. So even tests that are not decorated with Line 11: ValidateRunningAsRoot actually require root previliges. Line 12: Line 13: Change-Id: I3f85ea9ed7a8dd19f012d65b884998e525aa2259 -- To view, visit http://gerrit.ovirt.org/36049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f85ea9ed7a8dd19f012d65b884998e525aa2259 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
