Federico Simoncelli has posted comments on this change. Change subject: storageServer: Improve iscsi connection logging ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36028/1/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 414: return True Line 415: Line 416: def getSessionInfo(self): Line 417: for session in iscsi.iterateIscsiSessions(): Line 418: if self.isSession(session): > In line 422 I don't know why the session did not match, so it does not help Create a matchSession (or private _matchSession) method with the body of the current isSession that raises a descriptive SessionMatchError exception (instead of logging). Then isSession is just a wrapper around that (try / catch SessionMatchError to return True/False). Here you just need to keep the SessionMatchError and log them only when required. Line 419: self._lastSessionId = session.id Line 420: return session Line 421: Line 422: raise OSError(errno.ENOENT, "Session not found") -- To view, visit http://gerrit.ovirt.org/36028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de4ec72f09777e84273933ff41e9d1424e7aa09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
