Nir Soffer has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/33691/4//COMMIT_MSG Commit Message: Line 6: Line 7: utils: move nice ionice sid and sudo out of execCmd Line 8: Line 9: Utility commands as nice, ionice, setsid and sudo should be reusable Line 10: with regular Popen calls. In order to make them composable this patch Popen -> Popen/Cpopen We are not suggesting to replace CPopen with Popen. Line 11: moves them out of execCmd. Line 12: Line 13: Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 http://gerrit.ovirt.org/#/c/33691/4/lib/vdsm/Makefile.am File lib/vdsm/Makefile.am: Line 22: SUBDIRS=netlink tool infra Line 23: Line 24: dist_vdsmpylib_PYTHON = \ Line 25: __init__.py \ Line 26: cmdutils.py \ > Final name is still under discussion. I hope we can get a name without "utils" :-) Line 27: compat.py \ Line 28: define.py \ Line 29: exception.py \ Line 30: ipwrapper.py \ http://gerrit.ovirt.org/#/c/33691/4/vdsm.spec.in File vdsm.spec.in: Line 1252: %dir %{python_sitelib}/%{vdsm_name} Line 1253: %dir %{python_sitelib}/%{vdsm_name}/netlink Line 1254: %dir %{python_sitelib}/%{vdsm_name}/tool Line 1255: %{python_sitelib}/%{vdsm_name}/__init__.py* Line 1256: %{python_sitelib}/%{vdsm_name}/cmdutils.py* What about debian - don't we have to list the new file there? Line 1257: %{python_sitelib}/%{vdsm_name}/compat.py* Line 1258: %{python_sitelib}/%{vdsm_name}/config.py* Line 1259: %{python_sitelib}/%{vdsm_name}/constants.py* Line 1260: %{python_sitelib}/%{vdsm_name}/define.py* -- To view, visit http://gerrit.ovirt.org/33691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
