Dan Kenigsberg has posted comments on this change. Change subject: teach addNetwork to add a netwrok to an existing bridge ......................................................................
Patch Set 13: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35922/13/vdsm/network/api.py File vdsm/network/api.py: Line 317: if bridged and network in _netinfo.bridges: Line 318: net_ent_to_configure = net_ent.port Line 319: logging.info("Bridge %s already exists.", network) Line 320: # the bridge already exists and we attach a new underlying device to Line 321: # it. The we need to make sure that the bridge MTU configuration is Please refer to my formerly-posted nits. http://gerrit.ovirt.org/#/c/35922/11..13/vdsm/network/api.py Line 322: # updated. Line 323: configurator.configApplier.setIfaceMtu(network, mtu) Line 324: # we must also update the vms` tap devices (the bridge ports in this Line 325: # case) so that their MTU is synced with the bridge -- To view, visit http://gerrit.ovirt.org/35922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0df074c6c9d5f846748c2cff2cc14ba24305123b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
