Federico Simoncelli has posted comments on this change. Change subject: storageServer: Keep the original traceback ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/36331/1/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 208: try: Line 209: self._mount.mount(self.options, self._vfsType) Line 210: except MountError: Line 211: t, v, tb = sys.exc_info() Line 212: self.log.error("Mount failed: %s", e, exc_info=True) "e" here shouldn't exist anymore. Remove exc_info since we're at it. Line 213: try: Line 214: os.rmdir(self._getLocalPath()) Line 215: except OSError: Line 216: self.log.warn("Failed to remove mount point directory: %s", Line 214: os.rmdir(self._getLocalPath()) Line 215: except OSError: Line 216: self.log.warn("Failed to remove mount point directory: %s", Line 217: self._getLocalPath(), exc_info=True) Line 218: raise t, v, tb Just "raise" should have the same effect (you can remove the sys.exc_info part). Line 219: else: Line 220: try: Line 221: fileSD.validateDirAccess( Line 222: self.getMountObj().getRecord().fs_file) Line 226: self.disconnect() Line 227: except OSError: Line 228: self.log.warn("Error while disconnecting after access" Line 229: "problem", exc_info=True) Line 230: raise t, v, tb Same here. Line 231: Line 232: def isConnected(self): Line 233: return self._mount.isMounted() Line 234: -- To view, visit http://gerrit.ovirt.org/36331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I746cd71d065849dda7a2b53d7b74b53265a36b36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
