Dan Kenigsberg has posted comments on this change. Change subject: Fix schema ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Thanks for unbreaking the build! http://gerrit.ovirt.org/#/c/36427/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3870: {'type': 'HostDeviceParams', Line 3871: 'data': {'capability': 'str', 'iommu_group': 'uint', Line 3872: 'parent': 'str', 'product_id': 'str', 'product': 'str', Line 3873: 'vendor_id': 'str', 'vendor': 'str', 'totalvfs': 'uint', Line 3874: 'physfn':'str'}} Being optional, physfn should be marked with an asterisk. Line 3875: Line 3876: ## Line 3877: # @HostDevice: Line 3878: # -- To view, visit http://gerrit.ovirt.org/36427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28964143ae861d0c6237f648f11a0b27acc432f2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
