Dan Kenigsberg has posted comments on this change.

Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same 
subnet
......................................................................


Patch Set 23:

(1 comment)

http://gerrit.ovirt.org/#/c/31529/23/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:

Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
since the review of this patch is dragging on and on, would you be kind to 
split the creation of this sysctl module to its own patch?

I'd love to use it to disable ipv6 instead what's currently done in 
http://gerrit.ovirt.org/#/c/35061/11/tests/functional/networkTests.py
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yoav Kleinberger <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: jian wang <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to