Dan Kenigsberg has posted comments on this change. Change subject: fileSD: Optimize getAllVolumes on file storage ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36593/1/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 433 Line 434 Line 435 Line 436 Line 437 thanks for dropping this. Line 418: sd.DOMAIN_IMAGES, "*", "*.meta") Line 419: volMetaPaths = self.oop.glob.glob(volMetaPattern) Line 420: Line 421: # First create mapping from images to volumes Line 422: images = collections.defaultdict(list) using "set" here, instead of list, is conceptually better, as the order of volUUIDs is random. "set" makes this clear to the reader. Line 423: for metaPath in volMetaPaths: Line 424: head, tail = os.path.split(metaPath) Line 425: volUUID, volExt = os.path.splitext(tail) Line 426: imgUUID = os.path.basename(head) -- To view, visit http://gerrit.ovirt.org/36593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc19ce272b7e0b9c91d2f90aa46b5ddd21d69ece Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
