Dan Kenigsberg has posted comments on this change. Change subject: openstacknet: add support for using the midonet plugin ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36164/3/vdsm_hooks/openstacknet/after_device_migrate_destination.py File vdsm_hooks/openstacknet/after_device_migrate_destination.py: Line 4: # Licensed under the Apache License, Version 2.0 (the "License"); you may Line 5: # not use this file except in compliance with the License. You may obtain Line 6: # a copy of the License at Line 7: # Line 8: # http://www.apache.org/licenses/LICENSE-2.0 Vdsm is GPLv2+. I'm not sure if apache 2.0 is compatible with that. Would you consider making this hook GPLv2+, too? Line 9: # Line 10: # Unless required by applicable law or agreed to in writing, software Line 11: # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT Line 12: # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the -- To view, visit http://gerrit.ovirt.org/36164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d582810e93cb4670a0fb1f6b3524e57a2617ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ryu Ishimoto <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
