Francesco Romani has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 7: (1 comment) suggested import order http://gerrit.ovirt.org/#/c/36263/7/vdsm/v2v.py File vdsm/v2v.py: Line 21: Line 22: from vdsm import libvirtconnection Line 23: import logging Line 24: from vdsm.define import errCode Line 25: import caps Sorry to be picky, but, I'd suggest: from contextlib import closing import logging import xml.etree.ElementTree as ET import libvirt from vdsm.define import errCode from vdsm import libvirtconnection import caps Line 26: import libvirt Line 27: Line 28: Line 29: class InvalidVMConfiguration(ValueError): -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
