Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Split a DHCPv4-specific portion from a branch in _parse_lease_file ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/36836/3/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 526 Line 527 Line 528 Line 529 Line 530 I find elif family == 4 and line.startswith(EXPIRE): more readable. -- To view, visit http://gerrit.ovirt.org/36836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3367746310364be78be69b8c59528c2144f19d9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
