Nir Soffer has posted comments on this change. Change subject: bridge: Make VdsmError more verbose ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37015/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 33: Line 34: Line 35: class VdsmError(Exception): Line 36: def __init__(self, code, message): Line 37: Exception.__init__(self, code, message) This is more verbose but the logged error is not formatted in a nice way. VdsmError: (5, 'Error description') It should be something like this (similar to OSError): VdsmError: [error 5] Error description Line 38: self.code = code Line 39: self.message = message Line 40: Line 41: -- To view, visit http://gerrit.ovirt.org/37015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d41d0cf0494ed3e3a647d873bcff2f529dc2ee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
