Dan Kenigsberg has posted comments on this change. Change subject: vm: properly implement readPauseCode ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/37118/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2976: diskErrors = self._dom.diskErrors() Line 2977: for device, error in diskErrors.iteritems(): Line 2978: if error == libvirt.VIR_DOMAIN_DISK_ERROR_NO_SPACE: Line 2979: self.log.warning('device %s out of space', device) Line 2980: return 'ENOSPC' else: report EOTHER (or EIO), just in case someone else cares about our pauseCode. We can consider hiding pauseCode from Engine in a follow-up patch. Line 2981: return 'NOERR' Line 2982: Line 2983: def _timeoutExperienced(self, timeout): Line 2984: if timeout: -- To view, visit http://gerrit.ovirt.org/37118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f200e2856669bb7dbcc904898f326b939b1ddd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
