Liron Aravot has posted comments on this change. Change subject: monitor: return whether the reported status is real ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/37952/4/vdsm/storage/monitor.py File vdsm/storage/monitor.py: Line 170: self.domain = None Line 171: self.sdUUID = sdUUID Line 172: self.hostId = hostId Line 173: self.interval = interval Line 174: self.nextStatus = Status(actual=False) > I read it, self.nextStatus should not be non-actual. The fact that it is in I disagree, when it's being set here it's not an 'actual' status - only when _monitorDomain runs it contains an actual status. the actual flag replaces the firstChange flag and mimic the behavior. It's incorrect to set actual to True here - it should be either None or to be left as is. Line 175: self.status = FrozenStatus(self.nextStatus) Line 176: self.isIsoDomain = None Line 177: self.isoPrefix = None Line 178: self.lastRefresh = time.time() -- To view, visit http://gerrit.ovirt.org/37952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
