Dan Kenigsberg has posted comments on this change. Change subject: init: fix network service status checking ......................................................................
Patch Set 1: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/38173/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-25 19:40:32 +0100 Line 6: Line 7: init: fix network service status checking Line 8: Line 9: In init file, we check if network servuce is running by its status servuce->service Line 10: return code. Problem is, that this code is "always" 0, therefore we never Line 11: start network service when needed (for example, it's no autostarted Line 12: on CentOS 6). Line 13: Line 7: init: fix network service status checking Line 8: Line 9: In init file, we check if network servuce is running by its status Line 10: return code. Problem is, that this code is "always" 0, therefore we never Line 11: start network service when needed (for example, it's no autostarted no -> not Line 12: on CentOS 6). Line 13: Line 14: `service network status` returns lists of configured and active devices, Line 15: if the list of active devices (on the last row) does not contains all Line 16: VDSM's ONBOOT=yes devices, it means, that network service did not start Line 17: our devices and we should call service network start. Line 18: Line 19: Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Line 20: Bug-Url: https://bugzilla.redhat.com/1194553 there are strong doubts whether this solves the cited bug https://gerrit.ovirt.org/#/c/38173/1/init/sysvinit/vdsmd.init.in File init/sysvinit/vdsmd.init.in: Line 106: for dev in $interfaces; do Line 107: ifcfg="ifcfg-$dev" Line 108: grep -q '# Generated by VDSM version' "$ifcfg" || continue Line 109: grep -q 'ONBOOT=yes' "$ifcfg" || continue Line 110: grep -q 'IPADDR=' "$ifcfg" || continue I don't think you care to differentiate between static and dhcp interfaces here - you want to start both kinds in this stage. Line 111: static_devs="$static_devs $dev" Line 112: done Line 113: popd > /dev/null Line 114: Line 147: test_already_running && return 0 Line 148: Line 149: shutdown_conflicting_srv "${CONFLICTING_SERVICES}" || return 1 Line 150: start_needed_srv "${NEEDED_SERVICES}" || return 1 Line 151: start_network || return 1 We should take network off the NEEDED_SERVICES list. We should also start_network first, since it is known to be slow. Line 152: Line 153: # "service iscsid start" may not start becasue we configure node.startup to Line 154: # manual. See /etc/init.d/iscsid. Line 155: service iscsid status >/dev/null 2>&1 || service iscsid force-start \ -- To view, visit https://gerrit.ovirt.org/38173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfe796744e44af21f08974f2ccb4bbb503cc6d67 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
