Dan Kenigsberg has posted comments on this change. Change subject: network: support PCI passthrough of SR-IOV network interfaces. ......................................................................
Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38249/5/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: Line 74 Line 75 Line 76 Line 77 Line 78 killing this whitespace is not related to the patch. https://gerrit.ovirt.org/#/c/38249/5/vdsm/virt/vmdevices/hwclass.py File vdsm/virt/vmdevices/hwclass.py: Line 33: CONSOLE = 'console' Line 34: SMARTCARD = 'smartcard' Line 35: TPM = 'tpm' Line 36: HOSTDEV = 'hostdev' Line 37: INTERFACE = 'interface' We already have a NIC, with the same string as value. -- To view, visit https://gerrit.ovirt.org/38249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
