Francesco Romani has posted comments on this change. Change subject: hostdev: add hostdev device definition ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/37700/10/vdsm/hostdev.py File vdsm/hostdev.py: Line 185: def detach_detachable(device_name, only_get_params=False): Line 186: libvirt_device, device_params = _get_device_ref_and_params(device_name) Line 187: Line 188: if only_get_params: Line 189: return device_params I think it would be better (= nicer and more readable) if we instead add a little helper like def get_device_params(device_name): _, device_params = _get_device_ref_and_params(device_name) return device_params and the we use this new little helper from the outside, so this function can be left unchanged. Line 190: Line 191: iommu_group = device_params['iommu_group'] Line 192: Line 193: if device_params['capability'] in _UDEV_REQUIRING_CAPS: -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
