Timothy Asir has posted comments on this change. Change subject: lvm: Adds autobackup param in changelv and set the default value to false ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/38195/2//COMMIT_MSG Commit Message: Line 6: Line 7: lvm: Adds autobackup param in changelv and set the default value to false Line 8: Line 9: Currently autobackup option is set to false is used forcely in Line 10: most of the lvm function in storage.lvm. This will not allow > ^^ looks like there's a typo "is set to false is used forcely" Sure, i will correct this. Line 11: any call to automatically back up metadata after a change. Line 12: Line 13: This patch addes a parm to changelv and set the default value to Line 14: false. One can send true to change the option. However this change Line 11: any call to automatically back up metadata after a change. Line 12: Line 13: This patch addes a parm to changelv and set the default value to Line 14: false. One can send true to change the option. However this change Line 15: should be done in manyplace of the storage.lvm module like > ^^typo: mabyplace -> many place Sure, i will correct this. Line 16: lvcreate, lvremove and so on. Line 17: Line 18: Also currently most of the functions in lvm module accepts list Line 19: of params in a tuple format and have some mandatory options. Line 19: of params in a tuple format and have some mandatory options. Line 20: This will allow to break the lvm call if any thing called with Line 21: different option values in the tuple list which are now mandatory Line 22: to have some constant/'already defined' value. Line 23: ex:- changelv(vg, lvs, ('-autobackup', 'y')) > I'm not sure what do you mean here - is there a conflict between the new op Yes, currently its not possible to call this function with autoback true. For ex:- Currently this function adds ( "--autobackup", "n") argument to lvchange. [line no: 805 cmd.extend(LVM_NOBACKUP)] If someone calls with ('autobackup', 'y'), the lvchange command will have two different options for autoback one is set to false and another sets to true. ex: lvchange --autobackup n --autobackup y ... Line 24: Line 25: Change-Id: I8190878fe071fad46800e666795b94779d745abf -- To view, visit https://gerrit.ovirt.org/38195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8190878fe071fad46800e666795b94779d745abf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
