Francesco Romani has posted comments on this change. Change subject: devices: move and rename getUnderlyingDeviceAddress ......................................................................
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38714/2/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 506: Line 507: xml.dom.minidom.Element.writexml = __hacked_writexml Line 508: Line 509: Line 510: def device_address_from_xml(device_xml, index=0): even nicer :) Line 511: """ Line 512: Obtain device's address from libvirt Line 513: """ Line 514: address_xml = device_xml.getElementsByTagName('address')[index] -- To view, visit https://gerrit.ovirt.org/38714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
