Piotr Kliczewski has posted comments on this change. Change subject: detector ......................................................................
Patch Set 1: (1 comment) This patch seems to be work in progress I am not sure how it should work at this stage. Please update it or push follow-up patches so I know what we attempt to do with new classes defined here. http://gerrit.ovirt.org/#/c/37098/1/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 155: dispatcher.close() Line 156: Line 157: if not self._is_handshaking: Line 158: self._handshake_finished_handler(dispatcher) Line 159: Please add one more empty line. Line 160: class _Acceptor(object): Line 161: def __init__(self, reactor, detectors, dispatcher): Line 162: self._detectors = detectors Line 163: self._reactor = reactor -- To view, visit http://gerrit.ovirt.org/37098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
