Piotr Kliczewski has posted comments on this change. Change subject: stomp: use monotonic timer instead of clock ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/37056/5/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 473: def readable(self, dispatcher): Line 474: return True Line 475: Line 476: def _milis(self): Line 477: return int(round(elapsed_time() * 1000)) > Done I wanted to change it but checked first documentation and found: """ Return a 5-tuple of floating point numbers indicating accumulated (processor or other) times, in seconds """ so that means that we need to convert it to miliseconds so the code is OK. Line 478: Line 479: Line 480: class AsyncClient(object): Line 481: log = logging.getLogger("yajsonrpc.protocols.stomp.AsyncClient") -- To view, visit https://gerrit.ovirt.org/37056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
