Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/35935/9/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 304: self._transport.connect() Line 305: Line 306: def callMethod(self, methodName, params=[], rid=None): Line 307: resp = self.call(JsonRpcRequest(methodName, params, rid))[0] Line 308: if resp.error: is it possible to get AttributeError in this case? or error will always be part of the response ? why do you change the if "error" in resp? Line 309: raise JsonRpcError(resp.error['code'], resp.error['message']) Line 310: Line 311: return resp.result Line 312: -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
