Piotr Kliczewski has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/35940/10//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-07 22:57:37 +0200 Line 4: Commit: pkliczewski <[email protected]> Line 5: CommitDate: 2015-03-18 12:08:18 +0100 Line 6: Line 7: stomp: Pop the frame even if a frame handler isn't defined > ok, but why? We don't we need the hasattr() check anymore? Looking at the code all handlers have the method so no need to check. Will update message to be clear. Line 8: Line 9: Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Line 10: Signed-off-by: Saggi Mizrahi <[email protected]> -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
