Allon Mureinik has posted comments on this change. Change subject: Live Merge: work around racy libvirt pivot ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39303/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5072: # Line 5073: # TODO: Remove once we depend on a libvirt with this bug fixed. Line 5074: origVols = [x['volumeID'] for x in self.drive.volumeChain] Line 5075: alias = self.drive['alias'] Line 5076: while True: > Are we going to wait for this forever? Maybe we need timeout or retry count Agreed. The pivot may really fail for any number of reason, and we'll be stuck here Line 5077: chains = self.vm._driveGetActualVolumeChain([self.drive]) Line 5078: try: Line 5079: curVols = chains[alias] Line 5080: except KeyError: -- To view, visit https://gerrit.ovirt.org/39303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e794622baf66c75cbe583be03a7b9a4a7e4883d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
