Ido Barkan has posted comments on this change. Change subject: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39387/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-31 11:42:29 +0200 Line 4: Commit: Ondřej Svoboda <[email protected]> Line 5: CommitDate: 2015-03-31 12:02:05 +0200 Line 6: Line 7: vdsm_hooks: always build vmfex_dev (regardless of --enable-hooks) > There is no (technical) reason. The hook has been beneficial to users so th right! how about something along the lines of "This makes the hook shipped by default with VDSM rpm"? Line 8: Line 9: Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d https://gerrit.ovirt.org/#/c/39387/2/vdsm_hooks/Makefile.am File vdsm_hooks/Makefile.am: Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: SUBDIRS = \ > I break the long line here, yes, but only because vmfex_dev hook would not ok Line 22: ethtool_options \ Line 23: faqemu \ Line 24: ipv6 \ Line 25: macspoof \ -- To view, visit https://gerrit.ovirt.org/39387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ccf04b779f1f3c5eb113c44885cb40a9460942d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
