Allon Mureinik has posted comments on this change. Change subject: udevadm: Handle errors and timeouts in udevadm.settle() ......................................................................
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39594/2/vdsm/storage/udevadm.py File vdsm/storage/udevadm.py: Line 64: cmd = [_UDEVADM.cmd] Line 65: cmd.extend(args) Line 66: rc, out, err = utils.execCmd(cmd, raw=True) Line 67: if rc != 0: Line 68: raise Error(rc, out, err) Since this is the only place that the error is thrown and it's always caught in the calling function, I wonder if it's not simpler to just return the error. -- To view, visit https://gerrit.ovirt.org/39594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7eac964ca9bd399ff6e8a23d591a7f78651740f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
