Nir Soffer has posted comments on this change. Change subject: tests: reduce noice after running detector test ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/39031/6//COMMIT_MSG Commit Message: Line 6: Line 7: tests: reduce noice after running detector test Line 8: Line 9: We need to make sure that all the resources are closed properly during Line 10: tear down. We want to check whether the tests pass using m2c and > There was a reason why we do not depend on ssl module so I am not sure why The reason was that we wanted to share same ssl context in all connections. Before 3.4, we were not supporting http 1.1, and were creating an ssl context for each connection. Using M2Crypto, we can share the same context. In these tests, we don't have any reason to use 3rd party library, the builtin ssl module is just fine. Line 11: standard ssl module. As well as we want to get rid of AttributeError Line 12: while interpreter shutdown after running test suite. Line 13: Line 14: -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
