Freddy Rolland has posted comments on this change.

Change subject: sp: Add resizePV verb
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/39382/8/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 5106: # @storagedomainID:  The UUID of the Storage Domain
Line 5107: #
Line 5108: # @storagepoolID:    The UUID of the Storage Pool
Line 5109: #
Line 5110: # @guid:  A block device GUID
> Fix the indentation to match the other fields
Done
Line 5111: #
Line 5112: # Returns:
Line 5113: # The size in bytes of the device after resize
Line 5114: #


Line 5116: ##
Line 5117: {'command': {'class': 'StorageDomain', 'name': 'resizePV'},
Line 5118:  'data': {'storagedomainID': 'UUID', 'storagepoolID': 'UUID',
Line 5119:           'guid': 'str'},
Line 5120:   'returns': 'long'}
> Right - the indentation look wrong.
Done
Line 5121: 
Line 5122: ##
Line 5123: # @StorageDomain.format:
Line 5124: #


-- 
To view, visit https://gerrit.ovirt.org/39382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57e0fe4fad3e41cd6346b49623869c6d26afaa92
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Fred Rolland <froll...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to