Francesco Romani has posted comments on this change.

Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/39203/3/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 1: #
Any reason not to merge this into vdscli.py?
Line 2: # Copyright 2015 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


https://gerrit.ovirt.org/#/c/39203/3/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 23: from vdsm.utils import traceback
Line 24: 
Line 25: __all__ = ["betterAsyncore", "stompReactor", "stomp"]
Line 26: 
Line 27: CALL_TIMEOUT = 15
vaguely related, but I don't care that much (has to be introduced somewhere...)
Line 28: 
Line 29: _STATE_INCOMING = 1
Line 30: _STATE_OUTGOING = 2
Line 31: _STATE_ONESHOT = 4


-- 
To view, visit https://gerrit.ovirt.org/39203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Dima Kuznetsov <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to