Adam Litke has submitted this change and it was merged. Change subject: virt: Unify Drive size units ......................................................................
virt: Unify Drive size units Previously we used to keep some Drive size values in bytes and some in megabytes, and return next and max volume size in megabytes. We had lot of code converting sizes from megabytes to bytes. This mess makes the code harder to understand and error prone. Now we keep all size values in bytes and return next volume size in bytes, simplifying lot of code. Change-Id: Ice01c9706fc27d4472c90e47bf7e808564ba0bfe Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/37727 Reviewed-by: Adam Litke <[email protected]> --- M tests/vmStorageTests.py M vdsm/virt/vm.py M vdsm/virt/vmdevices/storage.py 3 files changed, 32 insertions(+), 30 deletions(-) Approvals: Nir Soffer: Verified Adam Litke: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice01c9706fc27d4472c90e47bf7e808564ba0bfe Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
