Adam Litke has posted comments on this change. Change subject: storage: Make Image.__chainSizeCalc public ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38995/3/vdsm/storage/image.py File vdsm/storage/image.py: Line 139: """ Line 140: randomStr = misc.randomStr(RENAME_RANDOM_STRING_LEN) Line 141: return "%s%s_%s" % (sd.REMOVED_IMAGE_PREFIX, randomStr, uuid) Line 142: Line 143: def chainSizeCalc(self, sdUUID, imgUUID, volUUID, size): > If this is public, we need a better name - how about estimatedChainSize() ? Done Line 144: """ Line 145: Compute an estimate of the whole chain size Line 146: using the sum of the actual size of the chain's volumes Line 147: """ -- To view, visit https://gerrit.ovirt.org/38995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id079eb5067c16f934370e42b5f4e09bbcef1512b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
