Dan Kenigsberg has posted comments on this change. Change subject: Don't prepare image with illegal volumes ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39302/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3233: imgPath = dom.activateVolumes(imgUUID, imgVolumes) Line 3234: if spUUID and spUUID != sd.BLANK_UUID: Line 3235: runImgPath = dom.linkBCImage(imgPath, imgUUID) Line 3236: else: Line 3237: runImgPath = imgPath Could you see if checking legality after image-wide activation is safe enough for this use case? Line 3238: Line 3239: leafPath = os.path.join(runImgPath, leafUUID) Line 3240: for volUUID in imgVolumes: Line 3241: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID, -- To view, visit https://gerrit.ovirt.org/39302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie543aeb8bdb52305419613ab6297681817124308 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
