Francesco Romani has posted comments on this change.

Change subject: virt: support per-vm stats age
......................................................................


Patch Set 34:

(1 comment)

https://gerrit.ovirt.org/#/c/38066/34/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 402: 
Line 403: 
Line 404: StatsSample = namedtuple('StatsSample',
Line 405:                          ['first_value', 'last_value',
Line 406:                           'values_interval', 'stats_age'])
> naming: "interval" seems crystal clear. "values_interval" is longer and add
good point, will change.
Line 407: 
Line 408: 
Line 409: EMPTY_SAMPLE = StatsSample(None, None, None, None)
Line 410: 


-- 
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to