Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Extract Drive.diskType property ......................................................................
virt: Extract Drive.diskType property This is the first step in breaking getXML() to separate methods for rendering individual elements, required to create replica disk xml without code duplication. The diskType property is also required for Ceph support, where it will be sent from the engine. This property helps the rest of the code to work in the same way if diskType was sent from the engine (new engine) or deduced from blockDev and networkDev properties (old engine). Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40062 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Adam Litke <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/virt/vmdevices/storage.py 1 file changed, 24 insertions(+), 9 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
