Yaniv Bronhaim has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool ......................................................................
Patch Set 6: (1 comment) replied to the comment https://gerrit.ovirt.org/#/c/39823/6/lib/vdsm/tool/configurators/passwd.py File lib/vdsm/tool/configurators/passwd.py: Line 49: def configure(): Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME) Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password()) Line 52: if rc != 0: Line 53: raise RuntimeError("Set password failed: %s" % (err,)) > should we persist the sasl db? Otherwise, we would call configure on every we currently run each boot https://github.com/oVirt/ovirt-node-plugin-vdsm/blob/master/hooks/on-boot/01-vdsm-configure so it won't be an issue.. Line 54: Line 55: Line 56: def removeConf(): Line 57: if isconfigured() == YES: -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
