Freddy Rolland has posted comments on this change. Change subject: hsm: Resizing the device if needed in getDeviceList ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/40469/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2048: try: Line 2049: if multipath.resize_if_needed(dev["guid"]): Line 2050: dev["capacity"] = str(multipath.getDeviceSize(dev["dm"])) Line 2051: except Exception as err: Line 2052: self.log.exception("Could not resize device:%s dm :%s %s", > Lets use same style of message you added in the other patches: Done Line 2053: dev["guid"], dev["dm"], err) Line 2054: Line 2055: pv = pvs.get(dev.get('guid', "")) Line 2056: if pv is not None: Line 2049: if multipath.resize_if_needed(dev["guid"]): Line 2050: dev["capacity"] = str(multipath.getDeviceSize(dev["dm"])) Line 2051: except Exception as err: Line 2052: self.log.exception("Could not resize device:%s dm :%s %s", Line 2053: dev["guid"], dev["dm"], err) > err is displayed as part of the traceback - the last line in the traceback Done Line 2054: Line 2055: pv = pvs.get(dev.get('guid', "")) Line 2056: if pv is not None: Line 2057: pvuuid = pv.uuid -- To view, visit https://gerrit.ovirt.org/40469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6b1b699b1a905e949e98f435f339a21dad640c6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches