Nir Soffer has posted comments on this change. Change subject: hsm: Support GUID list param in GetDeviceList ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40661/3/client/vdsClient.py File client/vdsClient.py: Line 717 Line 718 Line 719 Line 720 Line 721 Lets use a simpler user interface: getDeviceList [type [guid ...]] getDeviceList return all devices getDeviceList FCP return only FCP devices getDeviceList ISCSI guid1 guid2 return info for guid1 and guid2, assuming ISCSI type Please document this interface with all the examples in the help section, and it would be also nice to show this on the commit message. The implementation is much simpler: if len(args) == 0: devices = self.s.getDeviceList() else: devices = self.s.getDeviceList(args[0], args[1:]) And make sure empty guids list behave the same as None - actually, the default value should be an empty tuple, not None. -- To view, visit https://gerrit.ovirt.org/40661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
