Claude said: > > > and internally, the ServletToolboxManager would maintain a hashtable from > > the toolbox.xml real path to its specific instances (this > > > appears quite reasonable to have one manager per toolbox, no ?) > > > > yeah, this is pretty good. how/where are you planning to do the loading of > > the toolbox.xml file? > > the getManager can take care of it and call the load(InputStream) method if a new instance has to be built
+1 > > the ToolboxManager was not meant to be tied to the servlet API. > > Ah, right ! > > > just require that > > anyone plugging their own manager in make it extend ServletToolboxManager. > > (personally, i prefer the latter.) > > me too, that's the good solution > > > > By the way, shouldn't the VVS properties be prefixed by > > "org.apache.velocity.tools" ? > > > > eh, that doesn't really follow the pattern of most velocity.props keys. it > > of the ones that are inside the velocity.properties, that's true... > but not of the only one which is in the web.xml : > org.apache.velocity.properties = '/WEB-INF/velocity.properties' ah. i misunderstood. i thought you were talking about the key for specifying the ServletToolboxManager to be used. :) so, yeah, i think you're right. it would be better if the toolbox <init-param> key in were "org.apache.velocity.tools.toolbox" > So ? One prefix pattern for init-params and another for props files ? ;-) yeah. :) that's fine, they're two quite separate things. > > would be more inline to prefix VVS properties with something like > > "tools.view.servlet". so for the manager, i think > > "tools.view.servlet.toolbox.manager.class" would be a good key. > > As you wish, but we are speaking of a servlet init/context param, aren't we ? > Just as the "toolbox" param, which is not currently prefixed... as i wish? :) sheesh. i ain't even a committer here. the final word on these things belongs to Geir, Gabe, & company. we'll need them to commit these changes anyhow. (and even if i were one, i'd still want to know if you had another idea). Nathan Bubna [EMAIL PROTECTED] -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
