DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24584>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24584 Make VelocityViewServlet fall back to response.getOutputStream() if getWriter() fails ------- Additional Comments From [EMAIL PROTECTED] 2003-11-18 00:18 ------- looks better. however, the changes to init() seem needlessly complex. how's this instead: // For non Latin-1 encodings, ensure that the charset is // included in the Content-Type header. if (!DEFAULT_OUTPUT_ENCODING.equalsIgnoreCase(encoding)) { int index = defaultContentType.lastIndexOf("charset"); if (index < 0) { // the charset specifier is not yet present in header. // append character encoding to default content-type defaultContentType += "; charset=" + encoding; } else { // The user may have configuration issues. Velocity.warn("VelocityViewServlet: Charset was already " + "specified in the Content-Type property. " + "Output encoding property will be ignored."); } } also, i think the warnOfOutputStreamDeprecation variable shouldn't be static. we should warn once per instance of VelocityViewServlet. other than those things, i like this. i'm gonna go ahead and check it in (with my proposed changes :). --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
